Author terry.reedy
Recipients josh.r, rtpg, terry.reedy, xiang.zhang
Date 2017-04-07.21:10:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1491599452.44.0.970986918003.issue29989@psf.upfronthosting.co.za>
In-reply-to
Content
'crash' means OS message rather than Python exiting with exception traceback and message.

Can you post a minimal reproducer?  What OS?  subprocess.Popen._get_handles is different on POSIX and windows, though both seem to call f.fileno() without try-except. 

All filenoes are initialized to -1, so it seems to me that either
a. all accesses should be wrapped with try-except: pass, or
b. subprocess doc should say that file-like objects must include a fileno method returning -1.

I am puzzled though.  The 2.7 doc for (builtin)file.fileno() says 
"
Note
File-like objects which do not have a real file descriptor should not provide this method! "
"
Rather than return -1

In must be that the subprocess test does not test with a 'file-like object without a file descriptor'
History
Date User Action Args
2017-04-07 21:10:52terry.reedysetrecipients: + terry.reedy, josh.r, xiang.zhang, rtpg
2017-04-07 21:10:52terry.reedysetmessageid: <1491599452.44.0.970986918003.issue29989@psf.upfronthosting.co.za>
2017-04-07 21:10:52terry.reedylinkissue29989 messages
2017-04-07 21:10:52terry.reedycreate