Author giampaolo.rodola
Recipients giampaolo.rodola, gvanrossum, neologix, vstinner, yselivanov
Date 2017-04-07.13:39:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1491572386.67.0.193607596245.issue30014@psf.upfronthosting.co.za>
In-reply-to
Content
> The idea is to reuse _BaseSelectorImpl.register() and
> _BaseSelectorImpl.unregister() to factorize the code.

You can't factorize the logic of modify() into those as they do two different things. I also don't like repeating the same thing 3 times but given how the module is organized I'm not sure how to do that as I need to pass 3 things around: the low-level selector (epoll, poll, whatever) and the read and write constants (POLLIN, EPOLLIN) which change depending on the selector being used.
The same thing applies to the devpoll class (http://bugs.python.org/issue18931).
I can write a second patch which to refactor the whole module if that is desirable but I prefer to do that in another PR.
History
Date User Action Args
2017-04-07 13:39:46giampaolo.rodolasetrecipients: + giampaolo.rodola, gvanrossum, vstinner, neologix, yselivanov
2017-04-07 13:39:46giampaolo.rodolasetmessageid: <1491572386.67.0.193607596245.issue30014@psf.upfronthosting.co.za>
2017-04-07 13:39:46giampaolo.rodolalinkissue30014 messages
2017-04-07 13:39:46giampaolo.rodolacreate