Author martin.panter
Recipients Chi Hsuan Yen, berker.peksag, brett.cannon, ezio.melotti, josh.r, martin.panter, ned.deily, python-dev, vlee, willingc, zach.ware
Date 2017-04-03.13:06:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1491224805.6.0.0500436395099.issue23404@psf.upfronthosting.co.za>
In-reply-to
Content
I had mainly been using my boot-flag.patch with BSD Make (bmake) rather than Gnu Make. It seems I was relying on a bug in BSD Make that merges escaped newlines in command lines, despite Posix and Gnu Make. Anyway, Chi’s fix seems appropriate.

I am posting the patches I used for 3.5 and 2.7, in case others are interested. The 3.5 one would also need Chi’s fix merging the “_freeze_importlib” line.

It may be possible to have the configure script adjust the default for the BOOT flag rather than setting GENERATED_COMMENT. But the side effect would be disabling regeneration of additional things (e.g. that aren’t specifically broken with cross compilation.

Anyway my preference was to stop automatically regenerating files, and to keep the build system as simple as practical without hacks like the BOOT="#" flag.
History
Date User Action Args
2017-04-03 13:06:45martin.pantersetrecipients: + martin.panter, brett.cannon, ned.deily, ezio.melotti, python-dev, berker.peksag, zach.ware, willingc, josh.r, vlee, Chi Hsuan Yen
2017-04-03 13:06:45martin.pantersetmessageid: <1491224805.6.0.0500436395099.issue23404@psf.upfronthosting.co.za>
2017-04-03 13:06:45martin.panterlinkissue23404 messages
2017-04-03 13:06:44martin.pantercreate