This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients JelleZijlstra, ncoghlan, serhiy.storchaka
Date 2017-03-30.05:48:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
The __exit__() method doesn't conform PEP 8.

PEP 8: """Be consistent in return statements. Either all return statements in a function should return an expression, or none of them should. If any return statement returns an expression, any return statements where no value is returned should explicitly state this as return None , and an explicit return statement should be present at the end of the function (if reachable)."""

The __exit__() method has explicit "return False", bare "return", and implicit "return" at the end of the method. Together with different styles in different "except" clauses this makes it slightly hard to read.
Date User Action Args
2017-03-30 05:48:15serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, JelleZijlstra
2017-03-30 05:48:15serhiy.storchakasetmessageid: <>
2017-03-30 05:48:15serhiy.storchakalinkissue29692 messages
2017-03-30 05:48:15serhiy.storchakacreate