Author serhiy.storchaka
Recipients Jelle Zijlstra, ncoghlan, serhiy.storchaka
Date 2017-03-30.05:48:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1490852895.58.0.905124498354.issue29692@psf.upfronthosting.co.za>
In-reply-to
Content
The __exit__() method doesn't conform PEP 8.

PEP 8: """Be consistent in return statements. Either all return statements in a function should return an expression, or none of them should. If any return statement returns an expression, any return statements where no value is returned should explicitly state this as return None , and an explicit return statement should be present at the end of the function (if reachable)."""

The __exit__() method has explicit "return False", bare "return", and implicit "return" at the end of the method. Together with different styles in different "except" clauses this makes it slightly hard to read.
History
Date User Action Args
2017-03-30 05:48:15serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, Jelle Zijlstra
2017-03-30 05:48:15serhiy.storchakasetmessageid: <1490852895.58.0.905124498354.issue29692@psf.upfronthosting.co.za>
2017-03-30 05:48:15serhiy.storchakalinkissue29692 messages
2017-03-30 05:48:15serhiy.storchakacreate