Message290806
My apologies for breaking the world.
The workaround is to undefine PySlice_GetIndicesEx after #include "Python.h".
#if PY_VERSION_HEX < 0x03070000 && defined(PySlice_GetIndicesEx)
#undef PySlice_GetIndicesEx
#endif
But this restores the initial bug.
Other obvious solution -- declare 3.6.0 broken and require upgrading to 3.6.1.
For 3.5.4 we can disable defining the macro when Py_LIMITED_API is not defined. This will restore the initial bug in many extensions. And we need other way to detect if we compile the CPython core or standard extensions for fixing the bug in standard collections. Or expand all uses of PySlice_GetIndicesEx to PySlice_Unpack+PySlice_AdjustIndices (the patch can be generated automatically). |
|
Date |
User |
Action |
Args |
2017-03-30 05:09:17 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, larry, ned.deily, njs, steve.dower |
2017-03-30 05:09:17 | serhiy.storchaka | set | messageid: <1490850557.38.0.546249132185.issue29943@psf.upfronthosting.co.za> |
2017-03-30 05:09:17 | serhiy.storchaka | link | issue29943 messages |
2017-03-30 05:09:17 | serhiy.storchaka | create | |
|