Author martin.panter
Recipients Arfrever, benjamin.peterson, docs@python, martin.panter, r.david.murray, rhettinger, serhiy.storchaka, vstinner, zbysz
Date 2017-03-27.11:55:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1490615751.98.0.0951145779815.issue21071@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Victor, I’m not sure about changing the data type. As Python 3 grows older, there is potentially more code being written that you break by fixing a bug like this. It is incompatible if you used to write

>>> print(struct.Struct('hi').format.decode())
hi

I have used this decode() trick in the past to build composite format strings; e.g.: <https://bugs.python.org/issue16349#msg174083>. If you change the data type this code will raise AttributeError. At a minimum you should acknowledge it in the “porting” section of What’s New.

Also, if you make this change, maybe update the module doc string. See the end of format-str.patch.
History
Date User Action Args
2017-03-27 11:55:52martin.pantersetrecipients: + martin.panter, rhettinger, vstinner, benjamin.peterson, Arfrever, r.david.murray, zbysz, docs@python, serhiy.storchaka
2017-03-27 11:55:51martin.pantersetmessageid: <1490615751.98.0.0951145779815.issue21071@psf.upfronthosting.co.za>
2017-03-27 11:55:51martin.panterlinkissue21071 messages
2017-03-27 11:55:51martin.pantercreate