Message289804
LGTM, but I prefer `overflow > 0` over `overflow == 1`.
If use _testcapi the tests should be decorated with cpython_only. But I think that it is better to not use it. Limiting _length_ to C long (rather than size_t) is an implementation detail. The test with _length_ = 1 << 1000 should be enough. |
|
Date |
User |
Action |
Args |
2017-03-18 10:50:10 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, amaury.forgeotdarc, belopolsky, meador.inge, Oren Milman |
2017-03-18 10:50:10 | serhiy.storchaka | set | messageid: <1489834210.56.0.678231889326.issue29843@psf.upfronthosting.co.za> |
2017-03-18 10:50:10 | serhiy.storchaka | link | issue29843 messages |
2017-03-18 10:50:10 | serhiy.storchaka | create | |
|