➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients ncoghlan
Date 2017-03-12.06:13:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1489299211.77.0.0188090534059.issue29798@psf.upfronthosting.co.za>
In-reply-to
Content 
While backporting issue 29656 to get "make patchcheck" to play nice with git PR branches, I discovered an incompatibility between the way "git worktree" works and the assumptions in "patchcheck.py".

Specifically, in a worktree, ".git" is a file, rather than a directory:

    $ cat .git
    gitdir: /home/ncoghlan/devel/cpython/.git/worktrees/py27

So the current isdir() check should be relaxed to just an exists() check.
History
Date User Action Args
2017-03-12 06:13:31ncoghlansetrecipients: + ncoghlan
2017-03-12 06:13:31ncoghlansetmessageid: <1489299211.77.0.0188090534059.issue29798@psf.upfronthosting.co.za>
2017-03-12 06:13:31ncoghlanlinkissue29798 messages
2017-03-12 06:13:31ncoghlancreate