➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Oren Milman
Recipients Oren Milman, amaury.forgeotdarc, benjamin.peterson, flox, martin.panter, pitrou, serhiy.storchaka
Date 2017-03-08.10:05:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1488967544.86.0.538004959963.issue29741@psf.upfronthosting.co.za>
In-reply-to
Content 
I wrote a patch, but I attach it here and not in a PR, as you haven't approved
adding tests. (I would be happy to open a PR with or without the tests.)
I ran the test module (on my Windows 10), and seems like the patch doesn't
break anything.

also, while running test_memoryio with my added tests, i noticed some places in
Lib/_pyio.py which seemed like they should be changed.
in particular, I changed 'var.__index__' to 'var = var.__index__()' in some
places.
I feel really uncomfortable about that change, as it undos a change committed
by Florent Xicluna in b14930cd93e74cae3b7370262c6dcc7c28e0e712.
Florent, what was the reason for that change?
History
Date User Action Args
2017-03-08 10:05:45Oren Milmansetrecipients: + Oren Milman, amaury.forgeotdarc, pitrou, benjamin.peterson, flox, martin.panter, serhiy.storchaka
2017-03-08 10:05:44Oren Milmansetmessageid: <1488967544.86.0.538004959963.issue29741@psf.upfronthosting.co.za>
2017-03-08 10:05:44Oren Milmanlinkissue29741 messages
2017-03-08 10:05:44Oren Milmancreate