Author palaviv
Recipients berker.peksag, ced, ebarry, ghaering, lelit, palaviv, r.david.murray
Date 2017-02-28.19:57:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1488311850.87.0.807461558797.issue27645@psf.upfronthosting.co.za>
In-reply-to
Content
I actually looked at the patch and have a few comments:
1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep).
2. I think that the `pysqlite_connection_backup` function will look a lot better if you will have a cleanup/error label.

I am not a core developer but I think you should open the PR as it will be easier for the CR.
History
Date User Action Args
2017-02-28 19:57:30palavivsetrecipients: + palaviv, ghaering, ced, r.david.murray, berker.peksag, lelit, ebarry
2017-02-28 19:57:30palavivsetmessageid: <1488311850.87.0.807461558797.issue27645@psf.upfronthosting.co.za>
2017-02-28 19:57:30palavivlinkissue27645 messages
2017-02-28 19:57:30palavivcreate