This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients daves, jaysinh.shukla, ncoghlan, r.david.murray
Date 2017-02-25.05:00:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1487998833.44.0.561834894104.issue24241@psf.upfronthosting.co.za>
In-reply-to
Content
To summarise the changes that were made during the PR review, here's the eventual commit message for the merged PR:

============
 bpo-24241: Improve preferred webbrowser handling (#85)

- Add 'preferred' argument to webbrowser.register
- Use xdg-settings to specify preferred X browser

The first change replaces the existing undocumented tri-state
'try_order' parameter with the documented boolean keyword-only
'preferred' parameter. Setting it to True places the browser at the
front of the list, preferring it as the return to a subsequent get() call.

The second change adds a private `_os_preferred_browser` setting
and then uses that to make the default browser reported by
`xdg-settings` first in the try list when running under X (or
another environment that sets the `DISPLAY` variable).
This avoids the problem where the first entry in the tryorder
queue otherwise defaults to xdg-open, which doesn't support
the "new window" option.
============
History
Date User Action Args
2017-02-25 05:00:33ncoghlansetrecipients: + ncoghlan, r.david.murray, daves, jaysinh.shukla
2017-02-25 05:00:33ncoghlansetmessageid: <1487998833.44.0.561834894104.issue24241@psf.upfronthosting.co.za>
2017-02-25 05:00:33ncoghlanlinkissue24241 messages
2017-02-25 05:00:32ncoghlancreate