Author serhiy.storchaka
Recipients barry, ncoghlan, petr.viktorin, serhiy.storchaka
Date 2017-02-12.14:28:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1486909734.86.0.721049479861.issue29537@psf.upfronthosting.co.za>
In-reply-to
Content
Proposed patch is an alternative fix of issue27286 for Python 3.5. Rather than fixing the compiler and bumping the magic number it just avoids using incorrect value in eval loop. The patch can be useful for disro maintainers that don't want to recompile all .pyc files when update Python to 3.5.3. I think it would be the best way to fix issue27286. Now it can be combined with either reverting issue27286 changes or applying the workaround https://github.com/encukou/cpython/commit/magic-number-workaround .

The patch makes the high byte of oparg be used only when it is unambiguous (equal to 1). In that case the error message contains a function name. Otherwise the error message doesn't contain a function name. This is small usability regression, but the BUILD_MAP_UNPACK_WITH_CALL opcode is very rarely used and shouldn't raise an exception in normal case.
History
Date User Action Args
2017-02-12 14:28:54serhiy.storchakasetrecipients: + serhiy.storchaka, barry, ncoghlan, petr.viktorin
2017-02-12 14:28:54serhiy.storchakasetmessageid: <1486909734.86.0.721049479861.issue29537@psf.upfronthosting.co.za>
2017-02-12 14:28:54serhiy.storchakalinkissue29537 messages
2017-02-12 14:28:53serhiy.storchakacreate