Author Cornelius Diekmann
Recipients Alex.Willmer, Cornelius Diekmann, chris.torek, martin.panter, xdegaye
Date 2017-02-09.18:31:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1486665064.57.0.0396349671021.issue29070@psf.upfronthosting.co.za>
In-reply-to
Content
Uploaded a new version of the patch.

Changelog of this patch (compared to v3):
 * Fixed reliability issue of existing pty tests.
 * pty.fork() should now also work on systems without os.forkpty(). Added code to test this backup path of pty.fork().
 * Reverted my flawed changes to pty.py (broken pipe).
 * All new tests which produce output in the pty.spawn()ed child have the terminal in a well-defined state w.r.t. termios.
 * Subtle renaming: PtyTest is now PtyBasicTest. The reason is to execute it before the integration tests. All tests are independent and the order is irrelevant, but if something fails on a platform, it is easier to debug if we run the unit tests before we go to the integration tests.
 * Improved, cleaned, documented, and restructured test code. Thank you Xavier and Martin for your very helpful feedback :-)

I also added some small comments in the code review tool.
History
Date User Action Args
2017-02-09 18:31:06Cornelius Diekmannsetrecipients: + Cornelius Diekmann, xdegaye, martin.panter, Alex.Willmer, chris.torek
2017-02-09 18:31:04Cornelius Diekmannsetmessageid: <1486665064.57.0.0396349671021.issue29070@psf.upfronthosting.co.za>
2017-02-09 18:31:04Cornelius Diekmannlinkissue29070 messages
2017-02-09 18:31:04Cornelius Diekmanncreate