Message 287227 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	benjamin.peterson, brett.cannon, georg.brandl, methane, ncoghlan, serhiy.storchaka, vstinner, yselivanov
Date	2017-02-07.11:32:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1486467147.92.0.0470122601054.issue29469@psf.upfronthosting.co.za>
In-reply-to

Content
Do you mean https://github.com/pypa/pip/blob/403e398330c8e841e4633aceda859430f5f7b913/pip/_vendor/distlib/markers.py ? This doesn't affect, maybe. Constant folding is executed right before producing bytecode. It doesn't affect to PyCF_ONLY_AST. BTW, how do you feel asdl_ct.py? I feel it's too much only for constant folding, but it is too less for other advanced optimizations. Actually, original patch in #11549 implements other optimizations ported from peephole in compile.c. And most tough part of updating this patch is resolve conflict with this commit. https://github.com/python/cpython/commit/9cea398e237d4d75c6012e23a33d01b17f5dffcc I'll try to remove asdl_ct.py and ast_opt.ct in next version.

Do you mean https://github.com/pypa/pip/blob/403e398330c8e841e4633aceda859430f5f7b913/pip/_vendor/distlib/markers.py ?

This doesn't affect, maybe.
Constant folding is executed right before producing bytecode.
It doesn't affect to PyCF_ONLY_AST.

BTW, how do you feel asdl_ct.py?

I feel it's too much only for constant folding, but it is too less for other advanced optimizations.
Actually, original patch in #11549 implements other optimizations
ported from peephole in compile.c.
And most tough part of updating this patch is resolve conflict with this commit.
https://github.com/python/cpython/commit/9cea398e237d4d75c6012e23a33d01b17f5dffcc

I'll try to remove asdl_ct.py and ast_opt.ct in next version.

History
Date	User	Action	Args
2017-02-07 11:32:27	methane	set	recipients: + methane, brett.cannon, georg.brandl, ncoghlan, vstinner, benjamin.peterson, serhiy.storchaka, yselivanov
2017-02-07 11:32:27	methane	set	messageid: <1486467147.92.0.0470122601054.issue29469@psf.upfronthosting.co.za>
2017-02-07 11:32:27	methane	link	issue29469 messages
2017-02-07 11:32:27	methane	create