Author rhettinger
Recipients rhettinger, serhiy.storchaka, vstinner
Date 2017-02-06.07:32:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1486366376.62.0.184613989716.issue29452@psf.upfronthosting.co.za>
In-reply-to
Content
Over this looks good.  Just one other minor tweak (one that has served me well elsewhere) would be to bypass the cross-module function call with a cheap (near zero cost) register variable test:

    if (kwnames != NULL && !_PyArg_NoStackKeywords("rotate", kwnames)) {
        return NULL;
    }
History
Date User Action Args
2017-02-06 07:32:56rhettingersetrecipients: + rhettinger, vstinner, serhiy.storchaka
2017-02-06 07:32:56rhettingersetmessageid: <1486366376.62.0.184613989716.issue29452@psf.upfronthosting.co.za>
2017-02-06 07:32:56rhettingerlinkissue29452 messages
2017-02-06 07:32:56rhettingercreate