Message287091
Over this looks good. Just one other minor tweak (one that has served me well elsewhere) would be to bypass the cross-module function call with a cheap (near zero cost) register variable test:
if (kwnames != NULL && !_PyArg_NoStackKeywords("rotate", kwnames)) {
return NULL;
} |
|
Date |
User |
Action |
Args |
2017-02-06 07:32:56 | rhettinger | set | recipients:
+ rhettinger, vstinner, serhiy.storchaka |
2017-02-06 07:32:56 | rhettinger | set | messageid: <1486366376.62.0.184613989716.issue29452@psf.upfronthosting.co.za> |
2017-02-06 07:32:56 | rhettinger | link | issue29452 messages |
2017-02-06 07:32:56 | rhettinger | create | |
|