This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients larry, martin.panter, methane, python-dev, serhiy.storchaka, vstinner
Date 2017-02-02.12:25:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Martin> Shouldn’t the top-level unpack() parameter be called “buffer” like the other functions and methods, not “inputstr”?

Hum. I reopen the issue.

Attached patch renames unpack() "inputstr" argument to "buffer" and uses the Py_buffer type for it. I had to fix unit tests which passed str instead of bytes to buffer. Before this error was missed because the unit test is written to test the format string value, not the type of arguments.
Date User Action Args
2017-02-02 12:25:09vstinnersetrecipients: + vstinner, larry, methane, python-dev, martin.panter, serhiy.storchaka
2017-02-02 12:25:09vstinnersetmessageid: <>
2017-02-02 12:25:09vstinnerlinkissue29300 messages
2017-02-02 12:25:09vstinnercreate