āžœ

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Graham.Oliver, a.badger, ajaksu2, ezio.melotti, janssen, martin.panter, orsenthil, thezulk, vstinner
Date 2017-01-29.01:06:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1485652014.02.0.729738315483.issue3991@psf.upfronthosting.co.za>
In-reply-to
Content
Iā€™m not really an expert on non-ASCII URLs / IRIs. Maybe it is obvious to other people that this is a good general implementation, but for me to thoroughly review it I would need time to research the relevant RFCs, other implementations, suitability for the URL schemes listed at <https://docs.python.org/dev/library/urllib.parse.html>, security implications, etc.

One problem problem with using urlunsplit() is it would strip empty URL components, e.g. quote_iri("http://example/file#") -> "http://example/file". See Issue 22852. This is highlighted by the file:///[. . .] ā†’ file:/[. . .] test case.

FYI Martin Panter and vadmium are both just me, no need to get too excited. :) I just updated my settings for Rietveld (code review), so hopefully that is more obvious now.
History
Date User Action Args
2017-01-29 01:06:54martin.pantersetrecipients: + martin.panter, janssen, orsenthil, vstinner, ajaksu2, ezio.melotti, a.badger, thezulk, Graham.Oliver
2017-01-29 01:06:54martin.pantersetmessageid: <1485652014.02.0.729738315483.issue3991@psf.upfronthosting.co.za>
2017-01-29 01:06:54martin.panterlinkissue3991 messages
2017-01-29 01:06:53martin.pantercreate