Author serhiy.storchaka
Recipients methane, serhiy.storchaka, vstinner
Date 2017-01-22.12:53:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1485089598.99.0.10201128985.issue28999@psf.upfronthosting.co.za>
In-reply-to
Content
That is why I haven't pushed the patch. Thanks you for your LGTMs Victor and Inada, but this is not enough.

In general I think that it is better to use Py_RETURN_NONE than "Py_INCREF(Py_None); return Py_None;". Some replacements already was done in the past, and some currently reviewed patches include also such changes. This can distract attention from the main purpose of patches. I think that pushing all changes in one big commit will make less harm than add small changes in other patches here and there. Concinelle proved his reliability and it is easy to check these changes.

I'll push this patch if Raymond or other more conservative core developers accept it (or selected parts of it).
History
Date User Action Args
2017-01-22 12:53:19serhiy.storchakasetrecipients: + serhiy.storchaka, vstinner, methane
2017-01-22 12:53:18serhiy.storchakasetmessageid: <1485089598.99.0.10201128985.issue28999@psf.upfronthosting.co.za>
2017-01-22 12:53:18serhiy.storchakalinkissue28999 messages
2017-01-22 12:53:18serhiy.storchakacreate