Author mark.dickinson
Recipients juraj.sukop, mark.dickinson, pitrou, python-dev, serhiy.storchaka, skrah, vstinner
Date 2017-01-21.13:07:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1485004034.92.0.168061579243.issue29282@psf.upfronthosting.co.za>
In-reply-to
Content
Failures on the Windows buildbot (http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Non-Debug%203.x/builds/238/steps/test/logs/stdio) shown below.

It looks as though Windows is emulating the FMA operation on this machine (and not doing a particularly good job of it). That means that if we want to support Windows (and we do), we may have to emulate ourselves, preferably using something a bit more efficient than the fractions.Fraction module.

I'll let the buildbots complete, to see what else fails, and then roll back the commit. The patch clearly isn't good enough in its current state.


======================================================================
ERROR: test_fma_overflow (test.test_math.FMATests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_math.py", line 1565, in test_fma_overflow
    self.assertEqual(math.fma(a, b, -c),
OverflowError: overflow in fma

======================================================================
FAIL: test_fma_zero_result (test.test_math.FMATests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_math.py", line 1524, in test_fma_zero_result
    self.assertIsNegativeZero(math.fma(tiny, -tiny, 0.0))
  File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_math.py", line 1642, in assertIsNegativeZero
    msg="Expected a negative zero, got {!r}".format(value)
AssertionError: False is not true : Expected a negative zero, got 0.0

======================================================================
FAIL: test_random (test.test_math.FMATests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_math.py", line 1623, in test_random
    self.assertEqual(math.fma(a, b, c), expected)
AssertionError: 0.5506672157701096 != 0.5506672157701097
History
Date User Action Args
2017-01-21 13:07:14mark.dickinsonsetrecipients: + mark.dickinson, pitrou, vstinner, skrah, python-dev, serhiy.storchaka, juraj.sukop
2017-01-21 13:07:14mark.dickinsonsetmessageid: <1485004034.92.0.168061579243.issue29282@psf.upfronthosting.co.za>
2017-01-21 13:07:14mark.dickinsonlinkissue29282 messages
2017-01-21 13:07:14mark.dickinsoncreate