This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients georg.brandl, larry, martin.panter, python-dev, rhettinger, serhiy.storchaka, taleinat
Date 2017-01-20.17:17:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1484932661.37.0.172111478866.issue20186@psf.upfronthosting.co.za>
In-reply-to
Content
When reviewing AC patches, we should always compare the help() before and after.  

Also, if the code already had fast parsing like:
   if (!PyArg_UnpackTuple(args, "reversed", 1, 1, &seq) )
there needs to be a before and after timing to make sure there wasn't a performance regression.

When PyArg_NoKeywords was present, we need to verify that the AC version also precludes keyword arguments (to prevent the creation of unhelpful keyword args and to keep compatibility with other versions of Python).
History
Date User Action Args
2017-01-20 17:17:41rhettingersetrecipients: + rhettinger, georg.brandl, taleinat, larry, python-dev, martin.panter, serhiy.storchaka
2017-01-20 17:17:41rhettingersetmessageid: <1484932661.37.0.172111478866.issue20186@psf.upfronthosting.co.za>
2017-01-20 17:17:41rhettingerlinkissue20186 messages
2017-01-20 17:17:41rhettingercreate