Message285284
Added some review comments on the patch. The only critical one was changing a :class:`bytes` reference to :class:`unicode`, but I also suggested it may be worth mentioning that it *doesn't* enable warnings about all binary/text comparisons the way the Python 3 one does. |
|
Date |
User |
Action |
Args |
2017-01-12 03:26:37 | ncoghlan | set | recipients:
+ ncoghlan, lemburg, georg.brandl, ezio.melotti, eric.araujo, Arfrever, r.david.murray, docs@python, martin.panter, emily.zhao, gbengeult |
2017-01-12 03:26:37 | ncoghlan | set | messageid: <1484191597.92.0.889246117789.issue11681@psf.upfronthosting.co.za> |
2017-01-12 03:26:37 | ncoghlan | link | issue11681 messages |
2017-01-12 03:26:37 | ncoghlan | create | |
|