This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients methane, rhettinger, serhiy.storchaka
Date 2017-01-08.12:55:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483880155.63.0.262304619709.issue29202@psf.upfronthosting.co.za>
In-reply-to
Content
In general the idea LGTM. It it is slightly dangerous if dict structure is broken. j is incremented only when value != NULL, and if ma_used is not correct, this can cause reading out of the end of an array. Of course this should never happen. But if there is a chance to add some assertions or additional checks in debug mode, it would be nice. Unless this complicate the code to much.

The i counter is not used in some loops. It can be eliminated.
History
Date User Action Args
2017-01-08 12:55:55serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, methane
2017-01-08 12:55:55serhiy.storchakasetmessageid: <1483880155.63.0.262304619709.issue29202@psf.upfronthosting.co.za>
2017-01-08 12:55:55serhiy.storchakalinkissue29202 messages
2017-01-08 12:55:55serhiy.storchakacreate