Author martin.panter
Recipients Alex.Willmer, Cornelius Diekmann, chris.torek, martin.panter, vstinner
Date 2017-01-07.22:17:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483827422.69.0.853457996013.issue29070@psf.upfronthosting.co.za>
In-reply-to
Content
I would prefer to commit Chris’s fix for BSDs (Issue 26228) with a regression test. I can explain in the commit message who contributed to which part, or do two separate commits if you prefer. But the point is to add the test with the fix. I’m not going to commit the test on its own, because we know it will fail.

Even in Lib/test/test_pty.py, it looks like the two patches will collide. I was hoping you could combine the patches, or supply a set of patches that are tested and compatible. I don’t have OS X or BSD so I have to rely on you and the buildbots to confirm that a patch doesn’t break any tests.

I haven’t looked too closely regarding the slow tests, but another option is use the “cpu” resource to mark the test as being slow.

I realized that PtyWhiteBoxIntegrationTermiosTest is a reasonable test for the termios module, so it is beneficial. Though it may have been simpler to write it using pty.openpty(), avoiding an extra thread that just copies data between other threads.
History
Date User Action Args
2017-01-07 22:17:02martin.pantersetrecipients: + martin.panter, vstinner, Alex.Willmer, chris.torek, Cornelius Diekmann
2017-01-07 22:17:02martin.pantersetmessageid: <1483827422.69.0.853457996013.issue29070@psf.upfronthosting.co.za>
2017-01-07 22:17:02martin.panterlinkissue29070 messages
2017-01-07 22:17:02martin.pantercreate