Message284923
I'm generally a little concerned about the way "bugs" are presented here recently:
In #28701 you write:
'Correctness. Since no caller checks the error of PyUnicode_CompareWithASCIIString(), it is incorrectly interpreted as "less then".'
This is just not true. When testing for equality "-1" is "not equal"
and an exception would follow anyway.
I'm also not happy with broad coccinelle patches that I see months later.
I'm not sure if you realize that other people's reputation is at
stake here. You label something as a bug (good for you), everyone
who reads your reports and commits think that a bug has been found,
which is not the case. |
|
Date |
User |
Action |
Args |
2017-01-07 16:04:40 | skrah | set | recipients:
+ skrah, rhettinger, facundobatista, mark.dickinson, vstinner, serhiy.storchaka, xiang.zhang |
2017-01-07 16:04:40 | skrah | set | messageid: <1483805080.41.0.446602980606.issue29190@psf.upfronthosting.co.za> |
2017-01-07 16:04:40 | skrah | link | issue29190 messages |
2017-01-07 16:04:39 | skrah | create | |
|