Author xdegaye
Recipients vinay.sajip, xdegaye
Date 2017-01-07.15:07:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483801636.25.0.0304876383012.issue29177@psf.upfronthosting.co.za>
In-reply-to
Content
issue-29177-02.diff is a modified version of the previous patch that uses support.unlink() instead of os.remove() to handle the failure occuring for a non-existent file
when the test is skipped because of Permission denied. With this patch test_logging is ok, and test_lib2to3 runs fine after test_logging.

issue-29177-03.patch adds the following modifications to the previous patches:
  * Catch only OSError: it is better not to catch programming errors as they may go unnoticed when the test is skipped.
  * Report the OSError in the skip message.
  * Reduce the scope of the try clause to just the code that uses system calls.
  * The cleanup done in setUp() by the previous patch in the except clause does not seem to be needed as the tearDown() method is invoked when the test is skipped.
History
Date User Action Args
2017-01-07 15:07:16xdegayesetrecipients: + xdegaye, vinay.sajip
2017-01-07 15:07:16xdegayesetmessageid: <1483801636.25.0.0304876383012.issue29177@psf.upfronthosting.co.za>
2017-01-07 15:07:16xdegayelinkissue29177 messages
2017-01-07 15:07:15xdegayecreate