Author Segev Finer
Recipients Bernt.Røskar.Brenna, Segev Finer, eryksun, paul.moore, sbt, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-01-07.08:16:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483776995.1.0.375339851045.issue19764@psf.upfronthosting.co.za>
In-reply-to
Content
I removed previous_handle_list in _execute_child since I noticed subprocess already clobbers the other attributes in startupinfo anyhow.

I figured there will be some discussion about how to pass the handle list, so here's my two cents:

* subprocess already exposes a bit of Windows specific flags like creationflags and STARTUPINFO.

* Windows doesn't really break it's API in backwards incompatible ways often (Heck it barely breaks it ever, which is why we have so many Ex functions and reserved parameters :P).

* The _winapi module tries to expose WinAPI functions as is. So I implemented this as an internal attribute on STARTUPINFO, in the first version, since I wasn't sure we want this exposed to users, but I still wanted to try and mimic the original WinAPI functions internally. The lpAttributeList is a change requested by eryksun that brings it even closer to WinAPI and exposes it for further extension with additional attributes.
History
Date User Action Args
2017-01-07 08:16:35Segev Finersetrecipients: + Segev Finer, paul.moore, vstinner, tim.golden, Bernt.Røskar.Brenna, sbt, zach.ware, eryksun, steve.dower
2017-01-07 08:16:35Segev Finersetmessageid: <1483776995.1.0.375339851045.issue19764@psf.upfronthosting.co.za>
2017-01-07 08:16:35Segev Finerlinkissue19764 messages
2017-01-07 08:16:34Segev Finercreate