Author berker.peksag
Recipients Jiajun Huang, abarry, berker.peksag, michael.foord, python-dev, vstinner
Date 2017-01-07.05:04:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483765452.82.0.0907002148509.issue28961@psf.upfronthosting.co.za>
In-reply-to
Content
IIRC 3.5.3rc1 is already tagged so the 3.5 branch is open for 3.5.4. Anything that needs to be in 3.5.3 should be cherry-picked by the RM at this point if I'm not mistaken (and note that I don't have time check, but 3.5.3 may be the last bugfix release of 3.5 series so you may just skip 3.5 :))

Like I already said in msg284589, the test code doesn't follow the current style in Lib/unittest/test/testmock/testhelpers.py and it can be simplified like the following patch:

     def test_call_with_name(self):
-        self.assertEqual(
-            'foo',
-            _Call((), 'foo')[0],
-        )
-        self.assertEqual(
-            '',
-            _Call((('bar', 'barz'), ), )[0]
-        )
-        self.assertEqual(
-            '',
-            _Call((('bar', 'barz'), {'hello': 'world'}), )[0]
-        )
+        self.assertEqual(_Call((), 'foo')[0], 'foo')
+        self.assertEqual(_Call((('bar', 'barz'),),)[0], '')
+        self.assertEqual(_Call((('bar', 'barz'), {'hello': 'world'}),)[0], '')
History
Date User Action Args
2017-01-07 05:04:12berker.peksagsetrecipients: + berker.peksag, vstinner, michael.foord, python-dev, abarry, Jiajun Huang
2017-01-07 05:04:12berker.peksagsetmessageid: <1483765452.82.0.0907002148509.issue28961@psf.upfronthosting.co.za>
2017-01-07 05:04:12berker.peksaglinkissue28961 messages
2017-01-07 05:04:12berker.peksagcreate