Author vstinner
Recipients Bernt.Røskar.Brenna, Segev Finer, eryksun, paul.moore, sbt, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-01-06.22:51:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483743111.59.0.00714880377339.issue19764@psf.upfronthosting.co.za>
In-reply-to
Content
I dislike adding a lpAttributeList attribute: it's too close to the exact implementation of Windows may change in the future. I would prefer a more high level API.

Since the only known use case today is to pass handles, I propose to focus on this use case: add a new pass_handles parameter to Popen, similar to pass_fds.

I see that your patch is able to set close_fds to True on Windows: great job! It would be a great achievement to finally fix this last known race condition of subprocess on Windows!

So thank you for working on this!


> As for pass_fds: as you noted, it has it's own share of complexities and issues and I think it's best to leave it to a separate patch/issue.

pass_fds would be "nice to have", but I prefer to stick first to the native and well supported handles on Windows. For me, using file descriptors on Windows is more a "hack" to be able to write code working on Windows and UNIX, but since it's not natively supported on Windows, it comes with own set of issues.

IMHO it's better supported to work on handles.
History
Date User Action Args
2017-01-06 22:51:51vstinnersetrecipients: + vstinner, paul.moore, tim.golden, Bernt.Røskar.Brenna, sbt, zach.ware, eryksun, steve.dower, Segev Finer
2017-01-06 22:51:51vstinnersetmessageid: <1483743111.59.0.00714880377339.issue19764@psf.upfronthosting.co.za>
2017-01-06 22:51:51vstinnerlinkissue19764 messages
2017-01-06 22:51:51vstinnercreate