Author vstinner
Recipients Decorater, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-01-03.12:39:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483447144.29.0.920150372921.issue29063@psf.upfronthosting.co.za>
In-reply-to
Content
Downcasting to int doesn't seem good to me.

gmtoff_time_t.patch uses time_t instead of an int to store gmtoff. It raises an OverflowError if the value doesn't fit into a C long (at least max is at least 2^31).

I guess that the issue only impacts Windows, I expect that most platforms have a tm_zone field in the "tm" structure?

/* Define to 1 if `tm_zone' is a member of `struct tm'. */
#define HAVE_STRUCT_TM_TM_ZONE 1
History
Date User Action Args
2017-01-03 12:39:04vstinnersetrecipients: + vstinner, paul.moore, tim.golden, zach.ware, steve.dower, Decorater
2017-01-03 12:39:04vstinnersetmessageid: <1483447144.29.0.920150372921.issue29063@psf.upfronthosting.co.za>
2017-01-03 12:39:04vstinnerlinkissue29063 messages
2017-01-03 12:39:03vstinnercreate