Author steve.dower
Recipients Decorater, paul.moore, steve.dower, tim.golden, zach.ware
Date 2017-01-02.04:44:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483332282.91.0.974609785855.issue29063@psf.upfronthosting.co.za>
In-reply-to
Content
Any reason we can't make gmtoff a time_t instead of an int?

If we're going to truncate values to get rid of the warnings, I'd like to also see either proof that it will never exceed the size of an int (which may be a simple comment, but it's not obvious that this is the case from what appears in the patch), or an assertion when it does overflow.

But since we're presumably passing the value back into Python as an int, expanding the destination variable to fit all possible values is best.
History
Date User Action Args
2017-01-02 04:44:42steve.dowersetrecipients: + steve.dower, paul.moore, tim.golden, zach.ware, Decorater
2017-01-02 04:44:42steve.dowersetmessageid: <1483332282.91.0.974609785855.issue29063@psf.upfronthosting.co.za>
2017-01-02 04:44:42steve.dowerlinkissue29063 messages
2017-01-02 04:44:42steve.dowercreate