Author rhettinger
Recipients barry, eli.bendersky, ethan.furman, r.david.murray, realitix, rhettinger
Date 2016-12-30.05:19:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483075155.7.0.578406312951.issue29103@psf.upfronthosting.co.za>
In-reply-to
Content
I really don't like how this patch is done or even the spirit of it.  To my eyes, some of the code looks worse (especially the addition of trailing backslashes and some odd line-wraps that aren't sensitive to readability or context).

I'm going to close this.   If Ethan wants to make minor tweaks to his whitespace or line-wrapping, I believe he can do a better job with his own code.

Jean-Sebastien, thank you for trying to contribute, but PEP-8ing other people's code generally isn't helpful.  I recommend that you find a tracker item that needs a patch for a substantive change and work on that.  I think you will find it more satisfying and will have a much greater chance of acceptance.
History
Date User Action Args
2016-12-30 05:19:15rhettingersetrecipients: + rhettinger, barry, r.david.murray, eli.bendersky, ethan.furman, realitix
2016-12-30 05:19:15rhettingersetmessageid: <1483075155.7.0.578406312951.issue29103@psf.upfronthosting.co.za>
2016-12-30 05:19:15rhettingerlinkissue29103 messages
2016-12-30 05:19:14rhettingercreate