Author brendan-donegan
Recipients Brian Nenninger, brendan-donegan, rhettinger, steven.daprano
Date 2016-12-24.09:39:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1482572362.82.0.689106458748.issue29061@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, here it is. My first code patch in Python. 

Basically the existing code was depending on bit_length to DTRT and raise a ValueError, but negative numbers have a positive bit length. Then when it hits:

234             while r >= n:                                                        
235                 r = getrandbits(k)  

It just spins on that as r is always going to be greater than a negative number.

I tried not to be too clever so just put a guard early in the function. This has the added advantage of giving us a clearer error message.
History
Date User Action Args
2016-12-24 09:39:22brendan-donegansetrecipients: + brendan-donegan, rhettinger, steven.daprano, Brian Nenninger
2016-12-24 09:39:22brendan-donegansetmessageid: <1482572362.82.0.689106458748.issue29061@psf.upfronthosting.co.za>
2016-12-24 09:39:22brendan-doneganlinkissue29061 messages
2016-12-24 09:39:22brendan-donegancreate