Author xiang.zhang
Recipients serhiy.storchaka, steve.dower, vstinner, xiang.zhang
Date 2016-12-21.14:19:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1482329947.79.0.810221042209.issue29034@psf.upfronthosting.co.za>
In-reply-to
Content
Hmm, while considering Victor's comment, I find some new:

path->object refers to the original object o, it owns a borrowed reference. But when received a PathLike object, o is assigned the return value of __fspath__ and decrefed at end. So path->object could refer to a already freed object.

And the PyUnicode_AsWideCharString can't be simply replaced with PyUnicode_AsUnicodeAndSize since wo is decrefed and object->wide could then refer to freed memory.

The logic is complex and I get headache reading the code. Did I miss something?
History
Date User Action Args
2016-12-21 14:19:07xiang.zhangsetrecipients: + xiang.zhang, vstinner, serhiy.storchaka, steve.dower
2016-12-21 14:19:07xiang.zhangsetmessageid: <1482329947.79.0.810221042209.issue29034@psf.upfronthosting.co.za>
2016-12-21 14:19:07xiang.zhanglinkissue29034 messages
2016-12-21 14:19:07xiang.zhangcreate