Author xdegaye
Recipients martin.panter, xdegaye
Date 2016-12-20.19:36:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1482262602.11.0.195197989708.issue28997@psf.upfronthosting.co.za>
In-reply-to
Content
The test is ok on Android when LANG=en_US.UTF-8.
When LANG is not set, the check made by the first statement in test_nonascii() should skip the test but fails to skip it on Android as Py_EncodeLocale() always encode to utf8 whatever the locale (same as with darwin).
This patch adds a second check to verify that readline does handle multi bytes characters and does skip the test if not. So on Android the test is skipped now when LANG is not set.  Another solution would have been to set LANG=en_US.UTF-8 in the environment of the process forked by run_pty(), but it does not sound robust as there may be other setups where readline does not handle multi bytes characters.
History
Date User Action Args
2016-12-20 19:36:42xdegayesetrecipients: + xdegaye, martin.panter
2016-12-20 19:36:42xdegayesetmessageid: <1482262602.11.0.195197989708.issue28997@psf.upfronthosting.co.za>
2016-12-20 19:36:42xdegayelinkissue28997 messages
2016-12-20 19:36:41xdegayecreate