Author martin.panter
Recipients josh.r, larry, martin.panter, mdk, nadeem.vawda, python-dev, serhiy.storchaka, vajrasky, zach.ware
Date 2016-12-19.04:45:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1482122708.46.0.254873468565.issue20185@psf.upfronthosting.co.za>
In-reply-to
Content
I finished reviewing the most recent patches and left some comments. Perhaps it is worth splitting the conglomerate patch up. I don’t see any point holding back some modules while things are tweaked in unrelated files.

My biggest concern is casting function pointers, especially when the number of parameters is different than expected. It would be good to fix or discuss that more before going ahead with floatobject.c.
History
Date User Action Args
2016-12-19 04:45:08martin.pantersetrecipients: + martin.panter, larry, nadeem.vawda, python-dev, zach.ware, serhiy.storchaka, vajrasky, josh.r, mdk
2016-12-19 04:45:08martin.pantersetmessageid: <1482122708.46.0.254873468565.issue20185@psf.upfronthosting.co.za>
2016-12-19 04:45:08martin.panterlinkissue20185 messages
2016-12-19 04:45:07martin.pantercreate