This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients Cathy Avery, gregory.p.smith, kushal.das, r.david.murray
Date 2016-12-18.03:31:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
The second patch seems to be missing the configure changes.  Also, the tests have some over-long lines (we limit line lengths to 79 characters).  I realize there are other long lines in that file, but no need to add more :)

There is trailing whitespace on a number of lines in your patch.

Since this is new, we may not want to accept it until the support hits upstream.  Specifically, it will be difficult to get a review if the reviewer has to build a custom kernel to test the code :)  You do say that the VMCI is upstream, but I don't know what that means.  Which upstream?

Note: I'm not familiar with the socket C code, so I haven't reviewed the C code changes.  The tests look fine to me.

For the docs, the proposal doesn't seem to follow the format of the existing docs.  I would expect only the first paragraph located where you have it.  The remaining constants should be in the 'module contents'/'constants' section, I think.  Yes, that means each one gets a '.. versionadded' label.  Presumably also an 'availablility' label with whatever the minimum kernel version is...another reason we may need to wait.
Date User Action Args
2016-12-18 03:31:32r.david.murraysetrecipients: + r.david.murray, gregory.p.smith, kushal.das, Cathy Avery
2016-12-18 03:31:32r.david.murraysetmessageid: <>
2016-12-18 03:31:32r.david.murraylinkissue27584 messages
2016-12-18 03:31:30r.david.murraycreate