Message283181
Updated patch addresses Victor's issue. _PyDict_GET_SIZE is renamed to PyDict_GET_SIZE and now it includes an assertion. This is good argument for introducing this macro against using PyDict_Size (without checking the result for error) and Py_SIZE (which doesn't check the type).
> Can someone check if it has an impact of the size of the structure (because of the complex rules of alignment)?
There are special tests for that.
Actually I think that switching to PyObject_VAR_HEAD is different issue. The patch can be pushed without changes to dictobject.c and the structure of a dict. |
|
Date |
User |
Action |
Args |
2016-12-14 09:59:14 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, rhettinger, vstinner, methane |
2016-12-14 09:59:13 | serhiy.storchaka | set | messageid: <1481709553.93.0.476557965241.issue28959@psf.upfronthosting.co.za> |
2016-12-14 09:59:13 | serhiy.storchaka | link | issue28959 messages |
2016-12-14 09:59:13 | serhiy.storchaka | create | |
|