➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kumaar.nd
Recipients kumaar.nd, vstinner, xiang.zhang
Date 2016-12-13.11:56:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481630182.24.0.926010500735.issue28950@psf.upfronthosting.co.za>
In-reply-to
Content 
hi,
I reviewed the changes of patch set-2.
In the test_regrtest.py, instead of adding new condition
229:self.checkError([opt, '0', '-T'], "don't go together")
230:self.checkError([opt, '0', '-l'], "don't go together")
isnt it easier to just tweak and replace the existing 
227:self.checkError([opt, '2', '-T'], "don't go together")
228:self.checkError([opt, '2', '-l'], "don't go together")
with teh above changes?

If the suggestion sound naive, this is my first developer review and am new to python too.
History
Date User Action Args
2016-12-13 11:56:22kumaar.ndsetrecipients: + kumaar.nd, vstinner, xiang.zhang
2016-12-13 11:56:22kumaar.ndsetmessageid: <1481630182.24.0.926010500735.issue28950@psf.upfronthosting.co.za>
2016-12-13 11:56:22kumaar.ndlinkissue28950 messages
2016-12-13 11:56:22kumaar.ndcreate