Message282955
I decided to try a new direction.
Instead of modifying _TemporaryFileCloser to handle urllib, I've changed urllib classes to not inherit from _TemporaryFileCloser. The urllib classes are not temporary files as built by tempfile, so I believe this makes more sense. There is a small amount of code copied to the existing class, but I believe this cleans up the inheritance in a way that makes more sense for the given objects and requires fewer workarounds.
All feedback on this alternative approach is welcome. Thanks. |
|
Date |
User |
Action |
Args |
2016-12-12 00:46:07 | jdufresne | set | recipients:
+ jdufresne, vstinner, r.david.murray, SilentGhost |
2016-12-12 00:46:07 | jdufresne | set | messageid: <1481503567.16.0.0975103570553.issue28867@psf.upfronthosting.co.za> |
2016-12-12 00:46:07 | jdufresne | link | issue28867 messages |
2016-12-12 00:46:07 | jdufresne | create | |
|