This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jdufresne
Recipients SilentGhost, jdufresne, r.david.murray, vstinner
Date 2016-12-12.00:46:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481503567.16.0.0975103570553.issue28867@psf.upfronthosting.co.za>
In-reply-to
Content
I decided to try a new direction.

Instead of modifying _TemporaryFileCloser to handle urllib, I've changed urllib classes to not inherit from _TemporaryFileCloser. The urllib classes are not temporary files as built by tempfile, so I believe this makes more sense. There is a small amount of code copied to the existing class, but I believe this cleans up the inheritance in a way that makes more sense for the given objects and requires fewer workarounds.

All feedback on this alternative approach is welcome. Thanks.
History
Date User Action Args
2016-12-12 00:46:07jdufresnesetrecipients: + jdufresne, vstinner, r.david.murray, SilentGhost
2016-12-12 00:46:07jdufresnesetmessageid: <1481503567.16.0.0975103570553.issue28867@psf.upfronthosting.co.za>
2016-12-12 00:46:07jdufresnelinkissue28867 messages
2016-12-12 00:46:07jdufresnecreate