This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Thomas.Robitaille, martin.panter, mdk, ncoghlan, ned.deily, python-dev, serhiy.storchaka, vstinner
Date 2016-12-06.10:38:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481020735.41.0.64625490591.issue28835@psf.upfronthosting.co.za>
In-reply-to
Content
Julien reviewed the pushed change and asked me questions on IRC:

* "nonlocal log": this change is unrelated to the fix, I should have done that in a separated change, sorry, I cannot resist to refactoring :-) The change has no effect, it's more cosmetic to help reviewers: "log is not a local variable nor a global variable, it's a "non-local" variable".

* inner function (calling log.append) renamed from "showarnmsg()" to "showarnmsg_logger()": it's to help debugging. It's a pain when two different functions completely different have the same name, especially for the warnings where many functions are overriden at runtime. Moreover, the function is now used for _showwarnmsg_impl instead of _showwarnmsg, so I also renamed the function to avoid confusion.
History
Date User Action Args
2016-12-06 10:38:55vstinnersetrecipients: + vstinner, ncoghlan, ned.deily, python-dev, martin.panter, serhiy.storchaka, Thomas.Robitaille, mdk
2016-12-06 10:38:55vstinnersetmessageid: <1481020735.41.0.64625490591.issue28835@psf.upfronthosting.co.za>
2016-12-06 10:38:55vstinnerlinkissue28835 messages
2016-12-06 10:38:55vstinnercreate