This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients eric.smith, ncoghlan, serhiy.storchaka, vstinner
Date 2016-12-05.16:38:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480955897.25.0.718593728245.issue28838@psf.upfronthosting.co.za>
In-reply-to
Content
So, what do you think of renaming argument like:

* Replace "callable_object" and "func" with "callable"
* Replace "method" with "name"
* Rename "o" to "obj" (ex: in "PyCallable_Check(PyObject *o)")

I prefer "callable_object" over "callable" because it's shorter. Some functions already use "callable" (and so others use "callable_object").


Eric: ""Isn't this just a lot of churn for not a lot of benefit? I'm all for consistency, but you'll break patches on the bug tracker and externally maintained patches."

I'm not aware of any pending patch on "call" functions like PyObject_Call. I think that I am the latest who modified these functions. I'm working on a new patch serie to add support for fast calls in tp_call. That's why I would prefer to uniformize argument names first, before rebasing my large patch.
History
Date User Action Args
2016-12-05 16:38:17vstinnersetrecipients: + vstinner, ncoghlan, eric.smith, serhiy.storchaka
2016-12-05 16:38:17vstinnersetmessageid: <1480955897.25.0.718593728245.issue28838@psf.upfronthosting.co.za>
2016-12-05 16:38:17vstinnerlinkissue28838 messages
2016-12-05 16:38:16vstinnercreate