Author vstinner
Recipients python-dev, serhiy.storchaka, vstinner
Date 2016-12-04.22:13:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480889633.85.0.624745673359.issue28858@psf.upfronthosting.co.za>
In-reply-to
Content
> Serhiy Storchaka reported that Python 3.6 crashs earlier than Python 3.5 on calling json.dumps() when sys.setrecursionlimit() is increased.

Reference: http://bugs.python.org/issue23507#msg282190 (issue #23507).


Serhiy Storchaka: "Yes, that is why I asked you to revert your changes."

Sorry, I misunderstood your comments. So yes, my change b9c9691c72c5 introduced a regression. Sorry, I didn't have time before now to revert my  change. I just pushed the change d35fc6e58a70 which reverts b9c9691c72c5.

The question is how replacing PyObject_CallFunctionObjArgs() with _PyObject_CallArg1() increases the usage of the C stack. I wrote my change to reduce the usage of the C stack.

PyObject_CallFunctionObjArgs() allocates 5 "PyObject *", so 40 bytes, on the C stack. Maybe using _PyObject_CallArg1() increases the usage of C stack in the *caller*.


> In additional, they introduced compiler warnings.

This one was fixed by Benjamin Peterson in the issue #28855 (change 96245d4af0ca).
History
Date User Action Args
2016-12-04 22:13:53vstinnersetrecipients: + vstinner, python-dev, serhiy.storchaka
2016-12-04 22:13:53vstinnersetmessageid: <1480889633.85.0.624745673359.issue28858@psf.upfronthosting.co.za>
2016-12-04 22:13:53vstinnerlinkissue28858 messages
2016-12-04 22:13:53vstinnercreate