Author ncoghlan
Recipients eric.smith, inada.naoki, ncoghlan, rhettinger, serhiy.storchaka, xiang.zhang
Date 2016-12-01.14:30:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480602638.42.0.0748948364986.issue28638@psf.upfronthosting.co.za>
In-reply-to
Content
The concern with using the "generate a private module that can be cached" approach is that it doesn't generalise well - any time you want to micro-optimise a new module that way, you have to add a custom Makefile rule.

By contrast, Argument Clinic is a general purpose tool - adopting it for micro-optimisation in another file would just be a matter of adding that file to the list of files that trigger a clinic run. functools.py would be somewhat notable as the first Python file we do that for, but it isn't a novel concept overall.

That leads into my main comment on the AC patch: the files that are explicitly listed as triggering a new clinic run should be factored out into a named variable and that list commented accordingly.
History
Date User Action Args
2016-12-01 14:30:38ncoghlansetrecipients: + ncoghlan, rhettinger, eric.smith, inada.naoki, serhiy.storchaka, xiang.zhang
2016-12-01 14:30:38ncoghlansetmessageid: <1480602638.42.0.0748948364986.issue28638@psf.upfronthosting.co.za>
2016-12-01 14:30:38ncoghlanlinkissue28638 messages
2016-12-01 14:30:38ncoghlancreate