This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients eric.smith, ncoghlan, serhiy.storchaka, vstinner
Date 2016-12-01.08:46:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480581986.09.0.297136317183.issue28838@psf.upfronthosting.co.za>
In-reply-to
Content
> * Callable object: callable, o, callable_object => func

The original names better describes the argument type in functions like PyObject_Call(). It works not just with functions, but with arbitrary callables. For example it is used with type objects for creating instances.

> * Method name: name or nameid => method

The parameter is not a *method object*, but a method *name*. You have to pass an object and a method names to call a method.

> Serhiy: Can you please elaborate "Other changes looks not well justified too."?

Renaming obj to arg0 looks questionable to me. I would rather rename func to method (this is a true unbound method, not method name as in PyObject_CallMethod()).

It would be better to uniformize parameter names in the documentation (and perhaps in headers) and left sources untouched unless we rewrite particular functions. Otherwise it looks as code churn. It would be nice to formalize naming rules in PEP 7.

See also issue18697.
History
Date User Action Args
2016-12-01 08:46:26serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, vstinner, eric.smith
2016-12-01 08:46:26serhiy.storchakasetmessageid: <1480581986.09.0.297136317183.issue28838@psf.upfronthosting.co.za>
2016-12-01 08:46:26serhiy.storchakalinkissue28838 messages
2016-12-01 08:46:25serhiy.storchakacreate