Author vstinner
Recipients ezio.melotti, mrabarnett, python-dev, serhiy.storchaka, vstinner
Date 2016-11-23.13:15:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1479906946.36.0.759735787854.issue28765@psf.upfronthosting.co.za>
In-reply-to
Content
> It is too. But I meant the code parameter.

Oh ok. It seems like we use PyList_xxx() functions, so yeah, it seems safer (to respect the Python semantics) to only accept exactly the list type.


> Updated patch restricts _sre.compile() to accepting only exact collection types. I don't like this patch.

Why not? Do you prefer to accept subtypes?

sre-concrete-2.patch LGTM, I just added a minor comment.
History
Date User Action Args
2016-11-23 13:15:46vstinnersetrecipients: + vstinner, ezio.melotti, mrabarnett, python-dev, serhiy.storchaka
2016-11-23 13:15:46vstinnersetmessageid: <1479906946.36.0.759735787854.issue28765@psf.upfronthosting.co.za>
2016-11-23 13:15:46vstinnerlinkissue28765 messages
2016-11-23 13:15:46vstinnercreate