➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients SilentGhost, ezio.melotti, mrabarnett, serhiy.storchaka, vstinner
Date 2016-11-18.07:57:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1479455822.97.0.295965709537.issue28727@psf.upfronthosting.co.za>
In-reply-to
Content 
Patch version 3:

* pattern_hash() includes isbytes, I also shifted flags by 1 bit to not erase the isbytes bit (FYI maximum value of flags is 256)
* pattern_richcompare() avoids calling PyObject_RichCompareBool() if flags or isbytes is different
* unit test ensures that no BytesWarning warning is raised
* checks hash() in unit tests
* fix also the unit test with a different flag (use the same pattern)
* document also in the unit test that the comparison is case sensitive
History
Date User Action Args
2016-11-18 07:57:03vstinnersetrecipients: + vstinner, ezio.melotti, mrabarnett, SilentGhost, serhiy.storchaka
2016-11-18 07:57:02vstinnersetmessageid: <1479455822.97.0.295965709537.issue28727@psf.upfronthosting.co.za>
2016-11-18 07:57:02vstinnerlinkissue28727 messages
2016-11-18 07:57:02vstinnercreate