Message280902
It looks like Modules/selectmodule.c already has the handling for when this gets large (and we really want to stop allocating the static array on the stack), which is a plus, but I'd want to see the performance cost to small selects if suddenly we're allocating 100s of KB on the heap rather than small and cheap stack allocations.
For the amount of work going on here for each select() call, Victor is right - you're going to get severely diminishing returns as this increases in size.
However, I see no reason why this couldn't be totally dynamic, at least on Windows. Redefining that value just changes a static array definition, but the array size never gets passed in to the OS AFAICT, so there's no reason we couldn't stack allocate for small select()s and heap allocate for big select()s. That's considerably more work than anyone had in mind, I'd wager. |
|
Date |
User |
Action |
Args |
2016-11-15 23:42:24 | steve.dower | set | recipients:
+ steve.dower, paul.moore, vstinner, tim.golden, zach.ware, David Hirschfeld |
2016-11-15 23:42:24 | steve.dower | set | messageid: <1479253344.8.0.622636321975.issue28708@psf.upfronthosting.co.za> |
2016-11-15 23:42:24 | steve.dower | link | issue28708 messages |
2016-11-15 23:42:24 | steve.dower | create | |
|