This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author methane
Recipients methane, pitrou, python-dev, serhiy.storchaka, vstinner, yselivanov
Date 2016-11-15.12:04:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1479211446.64.0.271351136682.issue28618@psf.upfronthosting.co.za>
In-reply-to
Content
> so I suggest to run benchmarks and check that it has a non negligible effect on benchmarks ;-)

When added _Py_HOT_FUNCTION to lookdict_unicode, lookdict_unicode_nodummy and lookdict_split
(I can't measure L1 miss via `perf stat -d` because I use EC2 for benchmark):

$ ~/local/python-master/bin/python3 -m perf compare_to -G all-master.json all-patched.json
Slower (28):
- pybench.CompareFloats: 106 ns +- 1 ns -> 112 ns +- 1 ns: 1.07x slower
- pybench.BuiltinFunctionCalls: 1.62 us +- 0.00 us -> 1.68 us +- 0.03 us: 1.04x slower
- pybench.CompareFloatsIntegers: 180 ns +- 3 ns -> 185 ns +- 3 ns: 1.03x slower
- sympy_sum: 163 ms +- 7 ms -> 167 ms +- 7 ms: 1.03x slower
- deltablue: 13.7 ms +- 0.4 ms -> 14.1 ms +- 0.5 ms: 1.02x slower
- pickle_list: 5.77 us +- 0.09 us -> 5.90 us +- 0.07 us: 1.02x slower
- pybench.PythonFunctionCalls: 1.20 us +- 0.02 us -> 1.22 us +- 0.02 us: 1.02x slower
- pybench.SpecialClassAttribute: 1.46 us +- 0.02 us -> 1.49 us +- 0.03 us: 1.02x slower
- pybench.TryRaiseExcept: 207 ns +- 4 ns -> 210 ns +- 0 ns: 1.02x slower
- pickle_pure_python: 868 us +- 18 us -> 882 us +- 16 us: 1.02x slower
- genshi_text: 56.0 ms +- 0.7 ms -> 56.8 ms +- 0.6 ms: 1.01x slower
- json_dumps: 19.5 ms +- 0.3 ms -> 19.8 ms +- 0.2 ms: 1.01x slower
- richards: 137 ms +- 3 ms -> 139 ms +- 2 ms: 1.01x slower
- sqlalchemy_declarative: 272 ms +- 4 ms -> 276 ms +- 3 ms: 1.01x slower
- pickle_dict: 43.5 us +- 0.4 us -> 44.1 us +- 0.2 us: 1.01x slower
- go: 436 ms +- 4 ms -> 441 ms +- 4 ms: 1.01x slower
- pybench.SecondImport: 2.52 us +- 0.04 us -> 2.55 us +- 0.07 us: 1.01x slower
- pybench.NormalClassAttribute: 1.46 us +- 0.02 us -> 1.47 us +- 0.02 us: 1.01x slower
- genshi_xml: 118 ms +- 2 ms -> 118 ms +- 3 ms: 1.01x slower
- pybench.UnicodePredicates: 75.8 ns +- 0.6 ns -> 76.2 ns +- 0.9 ns: 1.01x slower
- pybench.ListSlicing: 415 us +- 4 us -> 417 us +- 4 us: 1.01x slower
- scimark_fft: 494 ms +- 2 ms -> 496 ms +- 12 ms: 1.01x slower
- logging_format: 23.7 us +- 0.3 us -> 23.9 us +- 0.4 us: 1.00x slower
- chaos: 200 ms +- 1 ms -> 201 ms +- 1 ms: 1.00x slower
- pybench.StringPredicates: 509 ns +- 3 ns -> 511 ns +- 4 ns: 1.00x slower
- call_method: 13.6 ms +- 0.1 ms -> 13.7 ms +- 0.2 ms: 1.00x slower
- pybench.StringSlicing: 530 ns +- 3 ns -> 532 ns +- 8 ns: 1.00x slower
- pybench.SimpleLongArithmetic: 535 ns +- 2 ns -> 536 ns +- 4 ns: 1.00x slower

Faster (47):
- html5lib: 169 ms +- 7 ms -> 158 ms +- 6 ms: 1.07x faster
- pybench.ConcatUnicode: 57.3 ns +- 3.0 ns -> 55.8 ns +- 1.3 ns: 1.03x faster
- pybench.IfThenElse: 60.5 ns +- 1.0 ns -> 59.0 ns +- 0.7 ns: 1.02x faster
- logging_silent: 606 ns +- 14 ns -> 593 ns +- 13 ns: 1.02x faster
- scimark_lu: 411 ms +- 5 ms -> 404 ms +- 4 ms: 1.02x faster
- pathlib: 29.1 ms +- 0.3 ms -> 28.7 ms +- 0.5 ms: 1.02x faster
- pybench.CreateStringsWithConcat: 2.87 us +- 0.01 us -> 2.82 us +- 0.00 us: 1.02x faster
- pybench.DictCreation: 621 ns +- 10 ns -> 612 ns +- 8 ns: 1.01x faster
- meteor_contest: 167 ms +- 5 ms -> 164 ms +- 5 ms: 1.01x faster
- unpickle_pure_python: 656 us +- 19 us -> 647 us +- 9 us: 1.01x faster
- pybench.NestedForLoops: 20.2 ns +- 0.1 ns -> 20.0 ns +- 0.1 ns: 1.01x faster
- regex_effbot: 4.01 ms +- 0.07 ms -> 3.95 ms +- 0.06 ms: 1.01x faster
- pybench.CreateUnicodeWithConcat: 57.1 ns +- 0.2 ns -> 56.4 ns +- 0.2 ns: 1.01x faster
- chameleon: 18.3 ms +- 0.2 ms -> 18.0 ms +- 0.3 ms: 1.01x faster
- python_startup: 13.7 ms +- 0.1 ms -> 13.5 ms +- 0.1 ms: 1.01x faster
- pybench.SmallTuples: 967 ns +- 6 ns -> 955 ns +- 8 ns: 1.01x faster
- pybench.TryFinally: 200 ns +- 3 ns -> 198 ns +- 2 ns: 1.01x faster
- pybench.SimpleIntegerArithmetic: 425 ns +- 3 ns -> 420 ns +- 4 ns: 1.01x faster
- pybench.Recursion: 1.34 us +- 0.02 us -> 1.33 us +- 0.03 us: 1.01x faster
- pybench.SimpleIntFloatArithmetic: 424 ns +- 1 ns -> 420 ns +- 1 ns: 1.01x faster
- float: 222 ms +- 2 ms -> 220 ms +- 3 ms: 1.01x faster
- 2to3: 531 ms +- 4 ms -> 527 ms +- 5 ms: 1.01x faster
- python_startup_no_site: 8.30 ms +- 0.04 ms -> 8.23 ms +- 0.05 ms: 1.01x faster
- xml_etree_parse: 196 ms +- 5 ms -> 194 ms +- 2 ms: 1.01x faster
- pybench.ComplexPythonFunctionCalls: 794 ns +- 7 ns -> 788 ns +- 7 ns: 1.01x faster
- logging_simple: 20.4 us +- 0.2 us -> 20.3 us +- 0.4 us: 1.01x faster
- fannkuch: 795 ms +- 9 ms -> 790 ms +- 3 ms: 1.01x faster
- hexiom: 18.7 ms +- 0.1 ms -> 18.6 ms +- 0.1 ms: 1.01x faster
- regex_compile: 322 ms +- 9 ms -> 320 ms +- 8 ms: 1.01x faster
- mako: 36.0 ms +- 0.1 ms -> 35.8 ms +- 0.2 ms: 1.01x faster
- pybench.UnicodeProperties: 91.7 ns +- 0.9 ns -> 91.1 ns +- 0.8 ns: 1.01x faster
- pybench.SimpleComplexArithmetic: 577 ns +- 8 ns -> 573 ns +- 3 ns: 1.01x faster
- xml_etree_process: 147 ms +- 2 ms -> 146 ms +- 2 ms: 1.01x faster
- pybench.CompareUnicode: 22.4 ns +- 0.1 ns -> 22.2 ns +- 0.1 ns: 1.01x faster
- crypto_pyaes: 175 ms +- 1 ms -> 174 ms +- 1 ms: 1.01x faster
- unpickle_list: 5.43 us +- 0.04 us -> 5.41 us +- 0.02 us: 1.01x faster
- pybench.WithFinally: 257 ns +- 4 ns -> 256 ns +- 2 ns: 1.01x faster
- xml_etree_generate: 183 ms +- 2 ms -> 182 ms +- 2 ms: 1.00x faster
- pybench.WithRaiseExcept: 475 ns +- 4 ns -> 472 ns +- 6 ns: 1.00x faster
- pybench.SecondPackageImport: 2.85 us +- 0.08 us -> 2.84 us +- 0.09 us: 1.00x faster
- pybench.SimpleListManipulation: 444 ns +- 1 ns -> 442 ns +- 2 ns: 1.00x faster
- spectral_norm: 208 ms +- 2 ms -> 208 ms +- 1 ms: 1.00x faster
- pybench.ForLoops: 8.95 ns +- 0.19 ns -> 8.94 ns +- 0.01 ns: 1.00x faster
- scimark_sor: 371 ms +- 3 ms -> 371 ms +- 2 ms: 1.00x faster
- scimark_sparse_mat_mult: 5.61 ms +- 0.06 ms -> 5.61 ms +- 0.36 ms: 1.00x faster
- pybench.UnicodeMappings: 40.7 us +- 0.1 us -> 40.7 us +- 0.0 us: 1.00x faster
- pybench.CompareStrings: 22.2 ns +- 0.0 ns -> 22.2 ns +- 0.0 ns: 1.00x faster

Benchmark hidden because not significant (47): call_method_slots, call_method_unknown, call_simple, django_template, dulwich_log, json_loads, nbody, nqueens, pickle, pidigits, pybench.BuiltinMethodLookup, pybench.CompareIntegers, pybench.
CompareInternedStrings, pybench.CompareLongs, pybench.ConcatStrings, pybench.CreateInstances, pybench.CreateNewInstances, pybench.DictWithFloatKeys, pybench.DictWithIntegerKeys, pybench.DictWithStringKeys, pybench.NestedListComprehensions
, pybench.NormalInstanceAttribute, pybench.PythonMethodCalls, pybench.SecondSubmoduleImport, pybench.SimpleDictManipulation, pybench.SimpleFloatArithmetic, pybench.SimpleListComprehensions, pybench.SmallLists, pybench.SpecialInstanceAttri
bute, pybench.StringMappings, pybench.TryExcept, pybench.TupleSlicing, pybench.UnicodeSlicing, raytrace, regex_dna, regex_v8, scimark_monte_carlo, sqlalchemy_imperative, sqlite_synth, sympy_expand, sympy_integrate, sympy_str, telco, torna
do_http, unpack_sequence, unpickle, xml_etree_iterparse
History
Date User Action Args
2016-11-15 12:04:06methanesetrecipients: + methane, pitrou, vstinner, python-dev, serhiy.storchaka, yselivanov
2016-11-15 12:04:06methanesetmessageid: <1479211446.64.0.271351136682.issue28618@psf.upfronthosting.co.za>
2016-11-15 12:04:06methanelinkissue28618 messages
2016-11-15 12:04:03methanecreate