This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author methane
Recipients methane, serhiy.storchaka, vstinner, xiang.zhang
Date 2016-11-03.01:49:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1478137745.04.0.953790213509.issue28580@psf.upfronthosting.co.za>
In-reply-to
Content
(Off topic note)

For readability, I prefer this style:

  PyDictKeyEntry *entries = DK_ENTRIES(mp->ma_keys);
  while (i < n && entries[i].me_value == NULL)
      i++;

But because sizeof(PyDictKeyEntry) is not 2^n, entries[i].me_value, i++
may be slower than entry_ptr->me_value, i++, entry_ptr++.

So we should prefer i++, entry_ptr++ style in case of iterating dict entries.
History
Date User Action Args
2016-11-03 01:49:05methanesetrecipients: + methane, vstinner, serhiy.storchaka, xiang.zhang
2016-11-03 01:49:05methanesetmessageid: <1478137745.04.0.953790213509.issue28580@psf.upfronthosting.co.za>
2016-11-03 01:49:04methanelinkissue28580 messages
2016-11-03 01:49:04methanecreate