Author yselivanov
Recipients Elvis.Pranskevichus, asvetlov, gvanrossum, inada.naoki, ned.deily, python-dev, vstinner, yselivanov
Date 2016-10-28.17:00:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1477674043.82.0.98034993686.issue28544@psf.upfronthosting.co.za>
In-reply-to
Content
I've committed the patch with a few touchups:

* Applied code-review feedback.

* We now use AC for all methods, including Task._repr_info, Task._step, etc. See [1].

* I fixed the Task to be fully subclassable; users can override Task._step and Task._wakeup now.  There are tests for ensuring that subclassing works the same for both Python and C implementations. See [2] and [3].

* I made it possible to override Future._schedule_subclass, as it was in Python 3.5. See [4].

Andrew, Inada-san, thank you for reviewing the patch!  Please take a look at the patch updates referenced below.  Feel free to re-open the issue if you see anything suspicious.

[1] https://github.com/1st1/cpython/commit/99adc35c94d76d78b8e666381436016c3c74a5ab

[2] https://github.com/1st1/cpython/commit/e294491c4cc7c92bc94ff12b4796c8ab12c40435

[3] https://github.com/1st1/cpython/commit/4d1c50c8987af124ce0bcccaea6bde82a60b59ee

[4] https://github.com/1st1/cpython/commit/efec03cbb4f81e78defd989d72c9bdae1122f50d
History
Date User Action Args
2016-10-28 17:00:43yselivanovsetrecipients: + yselivanov, gvanrossum, vstinner, ned.deily, asvetlov, inada.naoki, Elvis.Pranskevichus, python-dev
2016-10-28 17:00:43yselivanovsetmessageid: <1477674043.82.0.98034993686.issue28544@psf.upfronthosting.co.za>
2016-10-28 17:00:43yselivanovlinkissue28544 messages
2016-10-28 17:00:43yselivanovcreate